Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash versioning sub namespace service #3264

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix crash versioning sub namespace service #3264

merged 2 commits into from
May 3, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented May 2, 2024 •
edited
Loading

fix #3263

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 2, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/versioning
Show changes

@typespec/versioning - fix ✏️

Fix crash when @service inside a versioned namespace

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3264/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3264/

@timotheeguerin timotheeguerin added this pull request to the merge queue May 3, 2024
Merged via the queue into microsoft:main with commit fef1c39 May 3, 2024
21 checks passed
@timotheeguerin timotheeguerin deleted the fix/versioning-sub-namespace branch May 3, 2024 17:37
This was referenced Jul 5, 2024
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenjzhang allenjzhang allenjzhang approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding @service on sub namespace of versioned namespace that use dependency crash
3 participants
@timotheeguerin @azure-sdk @allenjzhang